search

AcademySoftwareFoundation / OpenShadingLanguage

Advanced shading language for production GI renderers
BSD 3-Clause "New" or "Revised" License
2.1k stars 360 forks source link

Testing: run pointcloud tests when partio is found #1611

Closed lgritz closed 2 years ago

lgritz commented 2 years ago

Wow, this has been lurking for a while. Our Findpartio.cmake tries looking for a partio exported config, but if not found, falls back to a simple code to find it manually.

All was fine with the fallback code, which if found would set both "partio_FOUND" and "PARTIO_FOUND". But the config file, if found -- only for the newer partio versions -- only set partio_FOUND. And in that circumstance, we were not seting up the pointcloud tests!

Although the partio tests were running in CI (thankfully), I was not running them locally on my machine with a new-ish partio.

lgritz commented 2 years ago

Just to clarify: If Partio was found, we did enable the pointcloud support, regardless of whether it was from an exported config or the find module. It was not a question of disabling the OSL code. But if it was from the exported config, we neglected to run the pointcloud-related tests in the testsuite.