AcademySoftwareFoundation / OpenShadingLanguage

Advanced shading language for production GI renderers
BSD 3-Clause "New" or "Revised" License
2.08k stars 352 forks source link

adding relaxed type-equivalency to ReParameter() #1639

Closed cmstein closed 1 year ago

cmstein commented 1 year ago

Signed-off-by: Clifford Stein cstein@imageworks.com

Description

Allows ShadingSystem->ReParameter() to use the same relaxed rules as SS->Parameter()

Tests

no changes in tests

Checklist:

lgritz commented 1 year ago

@cmstein, can you please fix the clang-format (a line each in typedesc.cpp and shadingsys.cpp) and also edit the last commit you have to be sure it has the "Signed-off-by:" message for the DCO? Thanks.

I tried to do this myself, but for some reason can't seem to push it back to your branch (despite the message saying "Add more commits by pushing to the relaxed_equiv branch on cmstein/OpenShadingLanguage.", which I should be able to do as the maintainer of the project. I'm not sure why this doesn't work.

cmstein commented 1 year ago

fixed clang-format issues and squashed the commits