AcademySoftwareFoundation / OpenShadingLanguage

Advanced shading language for production GI renderers
BSD 3-Clause "New" or "Revised" License
2.07k stars 350 forks source link

build(cmake): Fix incorrect variable name to control symbol visibility #1681

Closed lgritz closed 1 year ago

lgritz commented 1 year ago

As Fabrice Macagno pointed out on the oiio-dev mail list, we weren't setting the correct variable name CMAKE_CXX_VISIBILITY_PRESET.

And, oops, this also revealed that there were some things that needed to be declared public that were not (because, specifically, they needed to be called across library boundaries by the per-ISA dynamic libraries used by batch shading!).