AcademySoftwareFoundation / OpenShadingLanguage

Advanced shading language for production GI renderers
BSD 3-Clause "New" or "Revised" License
2.05k stars 348 forks source link

Restore stubs for printf (fixes OptiX problems with 1702) #1711

Closed lgritz closed 11 months ago

lgritz commented 11 months ago

The recently merged PR 1702 fails all the OptiX tests. I tracked down the problem and it's that the patch was a bit too aggressive about removing things no longer needed. The intent was that even if you don't use the new journaling, nothing should break. But it does break for OptiX, and this patch restores some of the functions 1702 removed (like the implementation of osl_printf) and some other necessary stubs.

This takes us from failing all ~150 OptiX oriented tests to failing only 4, which I believe are unrelated to 1702 and are merely revealed by them. I will fix those in a separate PR.