AcademySoftwareFoundation / OpenShadingLanguage

Advanced shading language for production GI renderers
BSD 3-Clause "New" or "Revised" License
2.09k stars 357 forks source link

fix: SymOverrideInfo bitfields should be the same type #1745

Closed lgritz closed 11 months ago

lgritz commented 11 months ago

Stephen Friedman alerted me to the fact that on Windows, bit fields within a struct will only be combined if they are the same type. We were a bit sloppy in the defintion of SymOverrideInfo, and that was causing the struct to end up a different size in Windows. I think the solution is that all those bit fields should be unsigned int.

sfriedmapixar commented 11 months ago

Thank you!