AcademySoftwareFoundation / OpenShadingLanguage

Advanced shading language for production GI renderers
BSD 3-Clause "New" or "Revised" License
2.05k stars 347 forks source link

build: Better cmake verbose behavior #1752

Closed lgritz closed 7 months ago

lgritz commented 7 months ago

When we bumped to cmake 3.15 minimum recently, we changed lots of constructs like this:

if (VERBOSE)
    message (STATUS "blah")
endif ()

to this:

message (VERBOSE "blah")

but I didn't realize that this was not enough, and to do it right requires CMAKE_MESSAGE_LOG_LEVEL. So even when VERBOSE=ON, we weren't actually getting all the verbose messages. Here, we fix it.

This mimics a similar recent fix in OIIO.