Use new OIIO ustringhash decode methods when available - Githubissues

AcademySoftwareFoundation / OpenShadingLanguage

Advanced shading language for production GI renderers

BSD 3-Clause "New" or "Revised" License

2.09k stars 356 forks source link

Use new OIIO ustringhash decode methods when available #1792

Closed chellmuth closed 6 months ago

chellmuth commented 6 months ago

Description

We noticed a few ustring-related performance regressions while converting Arnold to the new ustringhash pipeline.

These changes update relevant shadeops to avoid a ustringhash -> ustring conversion. The decode_wrapmode call into OIIO requires the latest master: https://github.com/AcademySoftwareFoundation/OpenImageIO/pull/4207/commits/6759d4d85dc6f41f16c56379d18daf4833663913

Tests

Checklist:

[x] I have read the contribution guidelines.
[x] I have updated the documentation, if applicable.
[x] I have ensured that the change is tested somewhere in the testsuite (adding new test cases if necessary).
[x] My code follows the prevailing code style of this project. If I haven't already run clang-format v17 before submitting, I definitely will look at the CI test that runs clang-format and fix anything that it highlights as being nonconforming.