AcademySoftwareFoundation / OpenShadingLanguage

Advanced shading language for production GI renderers
BSD 3-Clause "New" or "Revised" License
2.05k stars 347 forks source link

Remove the only use of boost::thread_specific_ptr #1802

Closed fpsunflower closed 2 months ago

fpsunflower commented 2 months ago

Description

This had already been marked as deprecated, and there is concensus that the overhead does not outweight the slight inconvenience of creating one object per thread

Tests

Testsuite passes on my machine.

Checklist:

lgritz commented 2 months ago

The Mac CI failures appear to be because Homebrew just upgraded to llvm 18 and we apparently have some fixups to do. They aren't related to your PR.

fpsunflower commented 2 months ago

Any notes on this one? I have the remaining boost removal changes queued up after this.