apetrynet
commented
1 year ago Hi TrevorAyl!
It seems your comments didn't make it into the comment stream on github. Would you mind summarizing your comments there so we have them recorded?
On Mon, Oct 23, 2023 at 12:47 AM TrevorAyl @.***> wrote:
Well I've had a little look - seems that the code is written assuming A mode. Not sure if explicitly setting the global_start_time to None is necessary but I added this when the timeline is initialized...
class EDLParser: def init(self, edl_string, rate=24, ignore_timecode_mismatch=False): self.timeline = schema.Timeline() self.timeline.global_start_time = None
Then added the following to the 'add_clip' function to set the global.start_time to be the first record_in the code comes across (I think, I'm not a coder).
` edl_rate = clip_handler.edl_rate record_in = opentime.from_timecode( clip_handler.record_tc_in, edl_rate )
# This should set the record_start to be the first record_in # The whole code does seem to assume A mode EDL # (i.e. so first event number would be first clip added and so earliest record in) if self.timeline.global_start_time is None: # Set the sequence start time self.timeline.global_start_time = record_in elif (record_in < self.timeline.global_start_time) raise EDLParseError( "Record In is less than Record Start: {} < {}" " for EDL event# {}".format( record_in, self.timeline.global_start_time, clip.num )) record_out = opentime.from_timecode( clip_handler.record_tc_out, edl_rate )`Apologies for not doing tests, submitting a pull request or whatever... I haven't learnt that bit yet...
Will do that next but probably won't get to it this week so if anyone more knowledgable can confirm I'm in the right ball park ? Thanks
— Reply to this email directly, view it on GitHub https://github.com/AcademySoftwareFoundation/OpenTimelineIO/issues/1385#issuecomment-1774220536, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIW7YKHMOTWQWFTOPRLNPLYAWPBVAVCNFSM57CH4B42U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCNZXGQZDEMBVGM3A . You are receiving this because you are subscribed to this thread.Message ID: <AcademySoftwareFoundation/OpenTimelineIO/issues/1385/1774220536@ github.com>
-- -Daniel
TrevorAyl
To Reproduce
Expected Behavior
I would expect that the first event's record start timecode would be set as the
global_start_timeon the timeline, and that theglobal_start_timeon the timeline would be the first event record time - rather than relying on thesource_rangeon tracks to set the time.