search

AcademySoftwareFoundation / OpenTimelineIO

Open Source API and interchange format for editorial timeline information.
http://opentimeline.io
Apache License 2.0
1.47k stars 293 forks source link

possible problem with gcc visibility decorations? #1569

Closed meshula closed 1 year ago

meshula commented 1 year ago

I think there may be an issue with visibility decorations on string exports on gcc?

Looking at the CI results on the C bindings

https://github.com/OpenTimelineIO/OpenTimelineIO-C-Bindings/actions

it seems that some exported strings are getting multiply-defined. Has anyone got insight into the issue seen there? I believe we probably need a fix here to address it.

JeanChristopheMorinPerso commented 1 year ago

@meshula is it the same issue as https://github.com/OpenTimelineIO/OpenTimelineIO-C-Bindings/issues/22?

meshula commented 1 year ago

Every time it comes up, I think I end up asking if anyone's able to offer help LOL. My suggestion last time was to replace the externed strings with accessor functions. I just keep hoping that eventually someone will have a simple non-intrusive fix, as my suggestion involves an API change.

reinecke commented 1 year ago

Closing as fixed under the C bindings #22 fix. There is more we could do on this (visibility decorators), however we can bring that as a separate issue later.

Per @meshula Should we build other bindings on top of the C bindings, we should take on visibility decorators to ensure our API surface area is explicit.