AcademySoftwareFoundation / OpenTimelineIO

Open Source API and interchange format for editorial timeline information.
http://opentimeline.io
Apache License 2.0
1.4k stars 276 forks source link

otiotool --redact doesn't redact media reference names #1678

Closed jminor closed 3 months ago

jminor commented 8 months ago

Bug Report

Incorrect Functionality

otiotool's --redact feature is supposed to remove all potentially sensitive information from an OTIO file, however it leaves the "name" attribute of MediaReference objects as-is. This could potentially reveal information about project names, talent, locations, dates, etc. which might be sensitive.

To Reproduce

redacted_media_out_of_bounds.otio.zip

  1. Download attached OTIO file, which is already redacted, but still has media reference names.
  2. Run `otiotool -i input.otio --redact -o output.otio
  3. Notice that output.otio still has names like "i345_13c" in it.

Expected Behavior

Media reference names should be replaced with anonymous names like "Media Reference #7".

apetrynet commented 3 months ago

Fixed in PR #1712