search

AcademySoftwareFoundation / OpenTimelineIO

Open Source API and interchange format for editorial timeline information.
http://opentimeline.io
Apache License 2.0
1.4k stars 276 forks source link

Redact media reference names #1712

Closed peter-targett closed 3 months ago

peter-targett commented 3 months ago

Pull Request is related to.

Fixes #1678

Summarize your change.

For otiotool --redact make sure to redact media reference names.

apetrynet commented 3 months ago

Hi @peter-targett Thank you for submitting a PR.

Not sure if it's related to the failed CI tests, but would you mind doing your changes in a feature branch? According to the contribution docs we shouldn't create PR's from main->main

jminor commented 3 months ago

This looks great! The test failure(s) seem unrelated to this change.

Something about

ModuleNotFoundError: No module named 'importlib_metadata'
  error: subprocess-exited-with-error

I'll press the Retry button to see if that helps.

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.76%. Comparing base (665c482) to head (9f26606).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/AcademySoftwareFoundation/OpenTimelineIO/pull/1712/graphs/tree.svg?width=650&height=150&src=pr&token=mfnfUB4h7u&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation)](https://app.codecov.io/gh/AcademySoftwareFoundation/OpenTimelineIO/pull/1712?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation) ```diff @@ Coverage Diff @@ ## main #1712 +/- ## ======================================= Coverage 79.76% 79.76% ======================================= Files 197 197 Lines 21846 21847 +1 Branches 4380 4380 ======================================= + Hits 17425 17426 +1 Misses 2246 2246 Partials 2175 2175 ``` | [Flag](https://app.codecov.io/gh/AcademySoftwareFoundation/OpenTimelineIO/pull/1712/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation) | Coverage Δ | | |---|---|---| | [py-unittests](https://app.codecov.io/gh/AcademySoftwareFoundation/OpenTimelineIO/pull/1712/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation) | `79.76% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/AcademySoftwareFoundation/OpenTimelineIO/pull/1712?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation) | Coverage Δ | | |---|---|---| | [...-opentimelineio/opentimelineio/console/otiotool.py](https://app.codecov.io/gh/AcademySoftwareFoundation/OpenTimelineIO/pull/1712?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation#diff-c3JjL3B5LW9wZW50aW1lbGluZWlvL29wZW50aW1lbGluZWlvL2NvbnNvbGUvb3Rpb3Rvb2wucHk=) | `66.30% <100.00%> (+0.09%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/AcademySoftwareFoundation/OpenTimelineIO/pull/1712?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/AcademySoftwareFoundation/OpenTimelineIO/pull/1712?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation). Last update [665c482...9f26606](https://app.codecov.io/gh/AcademySoftwareFoundation/OpenTimelineIO/pull/1712?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation).
jminor commented 3 months ago

Retry worked.

@apetrynet you're right that using a feature branch is a good practice, but I don't think we need @peter-targett to redo anything. The branch name will be irrelevant once this lands.

apetrynet commented 3 months ago

Thank you for your contribution @peter-targett !

peter-targett commented 3 months ago

I agree it could be on a branch but as 1 line change I did wonder if it could be pushed on main.Thanks, Peter On 26 Mar 2024, at 18:42, Joshua Minor @.***> wrote: Retry worked. @apetrynet you're right that using a feature branch is a good practice, but I don't think we need @peter-targett to redo anything. The branch name will be irrelevant once this lands.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>