AcademySoftwareFoundation / OpenTimelineIO

Open Source API and interchange format for editorial timeline information.
http://opentimeline.io
Apache License 2.0
1.4k stars 276 forks source link

Support for C++17 Part 2 #1713

Closed darbyjohnston closed 3 months ago

darbyjohnston commented 3 months ago

Fixes #1526

Changes:

This PR is a replacement for #1539 which is proving difficult to merge.

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 50.83056% with 148 lines in your changes are missing coverage. Please review.

Project coverage is 79.96%. Comparing base (afcb552) to head (d852d64).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/AcademySoftwareFoundation/OpenTimelineIO/pull/1713/graphs/tree.svg?width=650&height=150&src=pr&token=mfnfUB4h7u&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation)](https://app.codecov.io/gh/AcademySoftwareFoundation/OpenTimelineIO/pull/1713?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation) ```diff @@ Coverage Diff @@ ## main #1713 +/- ## ========================================== + Coverage 79.76% 79.96% +0.20% ========================================== Files 197 197 Lines 21847 21843 -4 Branches 4380 4333 -47 ========================================== + Hits 17426 17467 +41 - Misses 2246 2247 +1 + Partials 2175 2129 -46 ``` | [Flag](https://app.codecov.io/gh/AcademySoftwareFoundation/OpenTimelineIO/pull/1713/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation) | Coverage Δ | | |---|---|---| | [py-unittests](https://app.codecov.io/gh/AcademySoftwareFoundation/OpenTimelineIO/pull/1713/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation) | `79.96% <50.83%> (+0.20%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/AcademySoftwareFoundation/OpenTimelineIO/pull/1713?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation) | Coverage Δ | | |---|---|---| | [src/opentimelineio/anyVector.h](https://app.codecov.io/gh/AcademySoftwareFoundation/OpenTimelineIO/pull/1713?src=pr&el=tree&filepath=src%2Fopentimelineio%2FanyVector.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation#diff-c3JjL29wZW50aW1lbGluZWlvL2FueVZlY3Rvci5o) | `82.85% <ø> (ø)` | | | [src/opentimelineio/composable.h](https://app.codecov.io/gh/AcademySoftwareFoundation/OpenTimelineIO/pull/1713?src=pr&el=tree&filepath=src%2Fopentimelineio%2Fcomposable.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation#diff-c3JjL29wZW50aW1lbGluZWlvL2NvbXBvc2FibGUuaA==) | `100.00% <ø> (ø)` | | | [src/opentimelineio/composition.h](https://app.codecov.io/gh/AcademySoftwareFoundation/OpenTimelineIO/pull/1713?src=pr&el=tree&filepath=src%2Fopentimelineio%2Fcomposition.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation#diff-c3JjL29wZW50aW1lbGluZWlvL2NvbXBvc2l0aW9uLmg=) | `45.16% <100.00%> (+6.45%)` | :arrow_up: | | [src/opentimelineio/externalReference.cpp](https://app.codecov.io/gh/AcademySoftwareFoundation/OpenTimelineIO/pull/1713?src=pr&el=tree&filepath=src%2Fopentimelineio%2FexternalReference.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation#diff-c3JjL29wZW50aW1lbGluZWlvL2V4dGVybmFsUmVmZXJlbmNlLmNwcA==) | `76.92% <100.00%> (ø)` | | | [src/opentimelineio/externalReference.h](https://app.codecov.io/gh/AcademySoftwareFoundation/OpenTimelineIO/pull/1713?src=pr&el=tree&filepath=src%2Fopentimelineio%2FexternalReference.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation#diff-c3JjL29wZW50aW1lbGluZWlvL2V4dGVybmFsUmVmZXJlbmNlLmg=) | `100.00% <ø> (ø)` | | | [src/opentimelineio/generatorReference.cpp](https://app.codecov.io/gh/AcademySoftwareFoundation/OpenTimelineIO/pull/1713?src=pr&el=tree&filepath=src%2Fopentimelineio%2FgeneratorReference.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation#diff-c3JjL29wZW50aW1lbGluZWlvL2dlbmVyYXRvclJlZmVyZW5jZS5jcHA=) | `62.50% <100.00%> (ø)` | | | [src/opentimelineio/generatorReference.h](https://app.codecov.io/gh/AcademySoftwareFoundation/OpenTimelineIO/pull/1713?src=pr&el=tree&filepath=src%2Fopentimelineio%2FgeneratorReference.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation#diff-c3JjL29wZW50aW1lbGluZWlvL2dlbmVyYXRvclJlZmVyZW5jZS5o) | `100.00% <ø> (ø)` | | | [src/opentimelineio/imageSequenceReference.cpp](https://app.codecov.io/gh/AcademySoftwareFoundation/OpenTimelineIO/pull/1713?src=pr&el=tree&filepath=src%2Fopentimelineio%2FimageSequenceReference.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation#diff-c3JjL29wZW50aW1lbGluZWlvL2ltYWdlU2VxdWVuY2VSZWZlcmVuY2UuY3Bw) | `50.71% <100.00%> (+1.42%)` | :arrow_up: | | [src/opentimelineio/imageSequenceReference.h](https://app.codecov.io/gh/AcademySoftwareFoundation/OpenTimelineIO/pull/1713?src=pr&el=tree&filepath=src%2Fopentimelineio%2FimageSequenceReference.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation#diff-c3JjL29wZW50aW1lbGluZWlvL2ltYWdlU2VxdWVuY2VSZWZlcmVuY2UuaA==) | `48.27% <ø> (ø)` | | | [src/opentimelineio/item.cpp](https://app.codecov.io/gh/AcademySoftwareFoundation/OpenTimelineIO/pull/1713?src=pr&el=tree&filepath=src%2Fopentimelineio%2Fitem.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation#diff-c3JjL29wZW50aW1lbGluZWlvL2l0ZW0uY3Bw) | `60.71% <100.00%> (+5.42%)` | :arrow_up: | | ... and [31 more](https://app.codecov.io/gh/AcademySoftwareFoundation/OpenTimelineIO/pull/1713?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/AcademySoftwareFoundation/OpenTimelineIO/pull/1713/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/AcademySoftwareFoundation/OpenTimelineIO/pull/1713?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/AcademySoftwareFoundation/OpenTimelineIO/pull/1713?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation). Last update [afcb552...d852d64](https://app.codecov.io/gh/AcademySoftwareFoundation/OpenTimelineIO/pull/1713?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AcademySoftwareFoundation).