Closed vade closed 2 months ago
Attention: Patch coverage is 19.04762%
with 17 lines
in your changes are missing coverage. Please review.
Project coverage is 79.89%. Comparing base (
2b9c3a4
) to head (1207631
). Report is 1 commits behind head on main.
Thanks for your patience. DCO Sign off passed. I'll try to keep that in mind in the future!
Add implementation of
to_nearest_timecode
which makes approximate conversion of timecode from a rate using the closest valid time code rate.This is intended to fix various downstream adaptor hiccups where source material might be variable frame rate, or close but not quite an exact SMPTE timecode.
Link the Issue(s) this Pull Request is related to.
https://github.com/AcademySoftwareFoundation/OpenTimelineIO/issues/830
Summarize your change.
This PR does not directly fix the FCP_XML adaptor, but rather isolates changes to OTIO core and exposes a
to_nearest_timecode
with the same method signature asto_timecode
.This is intended to act as a entry point for changes to other adaptors if deemed a valid approach
Reference associated tests.
No new tests just yet.