AcademySoftwareFoundation / aswf-docker

Common container configuration
Apache License 2.0
145 stars 35 forks source link

OCIO VFX Platform 2020 Containers with Python 3 #75

Closed KelSolaar closed 3 years ago

KelSolaar commented 3 years ago

Hello,

I was looking at the current container definitions in the hope to use them for the OpenColorIO-Config-ACES repo but I see that the definitions are for Python 2.7 and VFX Platform 2019:

https://github.com/AcademySoftwareFoundation/aswf-docker/blob/master/ci-ocio/Dockerfile#L6

https://github.com/AcademySoftwareFoundation/aswf-docker/blob/master/ci-ocio/Dockerfile#L22

Even looking at what seems to be the cutting edge here: https://hub.docker.com/layers/aswf/ci-ocio/2021.1/images/sha256-7214648a6f878259024ad4f995c939f6e19a72168b1f70cbe06502f9a475d883?context=explore

I still see Python 2.7.

Did I miss something?

Cheers,

Thomas

aloysbaillet commented 3 years ago

Hi Thomas! The 2021 images definitely uses python-3.7. The ARG PYTHON_VERSION=2.7 is just the default value of the argument, if you look a few lines below you'll see the actual value used ENV PYTHONPATH=/usr/local/lib/python3.7.... I've just updated our image build process to add a templated README.md file and upload it to the image overview on dockerhub, see this test example: https://hub.docker.com/r/aswftesting/ci-base

KelSolaar commented 3 years ago

Yes, I saw (and used) that, I forgot to close the issue :)

Thank you!