search

AcademySoftwareFoundation / aswf-docker

Common container configuration
Apache License 2.0
145 stars 35 forks source link

vfxall clang containers not picking up correct clang version #86

Closed Idclip closed 3 years ago

Idclip commented 3 years ago

I've tried to switch to the new vfxall clang variants in some CI but I only seem to be picking up clang7. I'm getting the correct version of clang in the equivalent openvdb images. For example:

aswf/ci-vfxall:2019-clang8: https://github.com/Idclip/openvdb/runs/1280431746?check_suite_focus=true ASWF_VERSION=2019-clang8.10 CLANG_MAJOR_VERSION=7 picks up clang7, I expect clang8. I've tested for clang6, 8 and 9 - they all produce clang7

aswf/ci-openvdb:2019-clang8: https://github.com/Idclip/openvdb/runs/1280432068?check_suite_focus=true ASWF_VERSION=2019-clang8.6 CLANG_MAJOR_VERSION=8 correctly picks up clang8

I've configured the github actions CI in the same way for both, have I missed something? Thank you!

aloysbaillet commented 3 years ago

Hi Nick, sorry looks like I forgot something in the vfxall Dockerfile that explains the problem! I'll put a PR up tomorrow to fix it!

Idclip commented 3 years ago

No worries, thanks @aloysbaillet!