AcademySoftwareFoundation / opencue.io

Source for OpenCue website
https://www.opencue.io
Creative Commons Attribution 4.0 International
14 stars 27 forks source link

Add pip command to install Python dependencies #273

Closed n-jay closed 1 year ago

n-jay commented 1 year ago

Link the issue(s) this pull request is related to. Related discussion can be found on the dev mailing list thread linked here.

Summarize your change. Add command for OpenCue Python dependency installation on Ubuntu (and other Debian-based distros) via pip.

Existing documentation setup instructions via PyCharm IDE, which can result in some dependencies not being setup correctly.

bcipriano commented 1 year ago

@n-jay This PR is marked as a draft, is it ready for review? Just checking.

n-jay commented 1 year ago

yes @bcipriano, it's ready for review. Sent a draft assuming its standard protocol as per contributor instructions doc. Sorry for the confusion.

n-jay commented 1 year ago

@bcipriano something else I noticed in the doc were 2 redundant pip commands: https://github.com/AcademySoftwareFoundation/opencue.io/blob/df4cfa26b63c60dc1af2ab57a58100399c4974b3/content/contributing/opencue/Getting%20started/getting-started-linux.md?plain=1#L265

https://github.com/AcademySoftwareFoundation/opencue.io/blob/df4cfa26b63c60dc1af2ab57a58100399c4974b3/content/contributing/opencue/Getting%20started/getting-started-linux.md?plain=1#L285 They're present in the mac version as well.

These are used after the pip install -r is run when the 2 dependencies have already been set up. It's a super minor detail so it would be convenient if we can address it in this same PR instead of creating a fresh one.

bcipriano commented 1 year ago

Agreed, you can go ahead and remove those redundant installs in this PR.

n-jay commented 1 year ago

@bcipriano done