search

AcademySoftwareFoundation / openexr

The OpenEXR project provides the specification and reference implementation of the EXR file format, the professional-grade image storage format of the motion picture industry.
http://www.openexr.com/
BSD 3-Clause "New" or "Revised" License
1.63k stars 615 forks source link

Inconsistent line terminators (CRLF) #462

Closed axxel closed 5 years ago

axxel commented 5 years ago

Some of the following might be debatable but the CMakeLists.txt is definitively inconsistent with the rest of the repository (and standard practice):

file `find .` | grep CRLF
./ASWF/tsc-meetings/2019-06-13.md:                                      UTF-8 Unicode (with BOM) English text, with CRLF line terminators
./ASWF/tsc-meetings/2019-06-27.md:                                      UTF-8 Unicode (with BOM) English text, with CRLF line terminators
./Contrib/Photoshop/win32/EXRformat-sym.h:                              ASCII C++ program text, with CRLF line terminators
./Contrib/Photoshop/win32/EXRFormat.rc:                                 ASCII C++ program text, with CRLF line terminators
./Contrib/Photoshop/win32/EXRFormat.sln:                                ASCII text, with CRLF line terminators
./PyIlmBase/CMakeLists.txt:                                             ASCII English text, with CRLF line terminators
kdt3rd commented 5 years ago

I think we'll leave the dos-style files alone in the contrib folder, as those are specific for windows, and don't know if visual studio has any particular requirements there. thanks for noticing these inconsistencies!

cary-ilm commented 5 years ago

I created the meeting minutes .md files via copy/paste from google docs, I'm not sure where the weird characters would have been introduced, but I'll look out for it in the future.

And I'm pretty sure we can delete the Photoshop plugin in Contrib altogether, it's ancient, the extra line feeds were probably introduced in the conversion from punch cards ;)

On Mon, Jul 22, 2019 at 1:51 PM Kimball Thurston notifications@github.com wrote:

Closed #462 https://github.com/openexr/openexr/issues/462.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/openexr/openexr/issues/462?email_source=notifications&email_token=AFC3DGKXJ4JRGAV7TOOGOZ3QAYMWFA5CNFSM4IFFYYM2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSUJWHII#event-2501075873, or mute the thread https://github.com/notifications/unsubscribe-auth/AFC3DGOIVTB4FBMXQ7O7GMLQAYMWFANCNFSM4IFFYYMQ .

-- Cary Phillips | R&D Supervisor | ILM | San Francisco

meshula commented 5 years ago

Side note on Photoshop plugins: OpenEXR is natively supported for import and export in Photoshop, although support is basic. There's this very nice looking plug here - https://www.exr-io.com/ - but it's only available for Windows.

cary-ilm commented 5 years ago

There's also ProExr: https://www.fnordware.com/ProEXR

On Tue, Jul 23, 2019 at 10:11 AM Nick Porcino notifications@github.com wrote:

Side note on Photoshop plugins: OpenEXR is natively supported for import and export in Photoshop, although support is basic. There's this very nice looking plug here - https://www.exr-io.com/ - but it's only available for Windows.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/openexr/openexr/issues/462?email_source=notifications&email_token=AFC3DGN4DRRIBLPOZUXUPQLQA43V3A5CNFSM4IFFYYM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2TZXZI#issuecomment-514300901, or mute the thread https://github.com/notifications/unsubscribe-auth/AFC3DGK6AGE5NVRTSUQVIZ3QA43V3ANCNFSM4IFFYYMQ .

-- Cary Phillips | R&D Supervisor | ILM | San Francisco