search

AcademySoftwareFoundation / openfx

OpenFX effects API
Other
410 stars 120 forks source link

Resolves: #99, remove redundant typedefs #100

Closed fxtech closed 1 year ago

fxtech commented 1 year ago

Removes redundant typedefs from ofxDrawSuite.h

fxtech commented 1 year ago

It was my understanding that it was the extra unnecessary typedefs before the enum and struct declarations.

I don't think enum is used in front of variable declarations anywhere.

On 11/10/22 5:31 PM, GaryO wrote:

@.**** commented on this pull request.

I'm curious; why are these redundant? Isn't it nicer to be able to say (for example)

OfxStandardColor color =kOfxStandardColourOverlayText;

than

|enum OfxStandardColor color = kOfxStandardColourOverlayText; |

? Or is it considered more explicit for users to have to write out the |enum|? (And same for the structs)

What errors have folks seen?

— Reply to this email directly, view it on GitHub https://github.com/ofxa/openfx/pull/100#pullrequestreview-1176621703, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAM64ASRWAY6CPGL65XZ57TWHWATRANCNFSM6AAAAAAR2SGWWE. You are receiving this because you authored the thread.Message ID: @.***>

john-paulsmith commented 1 year ago

This is a difference between C and C++. In C++, the typedef is unnecessary and might generate a compiler warning, but in pure C, @garyo's observation is correct.