search

AcademySoftwareFoundation / openfx

OpenFX effects API
Other
410 stars 120 forks source link

Move OpenGL suite & CUDA/Metal/OpenCL into new ofxGPURender.h #107

Closed garyo closed 1 year ago

garyo commented 1 year ago

The new props should not have been in the main ofxImageEffect.h; moved them into the new file, along with the content of ofxOpenGLRender.h which now just includes the new ofxGPURender.h.

I also added #pragma once to some of the headers and fixed a missing #include. These should be done globally, IMHO. Also improved the doc for some of the new props.

garyo commented 1 year ago

Is there any reason to wait on merging this?

Dithermaster commented 1 year ago

It doesn't have the OpenCL image parts (combined header) just the BMD buffer part. If this can be added later, then OK to merge. If you want it included, then I need to add it.

garyo commented 1 year ago

Thanks for catching the missing OpenCL! It's probably simplest for me to merge this and then you can fix up OpenCL (rather than trying to patch my PR).