search

AcademySoftwareFoundation / openfx

OpenFX effects API
Other
393 stars 119 forks source link

Gpu gain example #132

Closed garyo closed 4 months ago

SonyDennisAdams commented 5 months ago

The build folder structure for GPUGain does not match the other examples: build\Examples\GPUGain\Release\example-GPUGain.ofx. <= different than the rest build\Examples\Release\example-Basic.ofx build\Examples\Release\example-Custom.ofx build\Examples\Release\example-DepthConverter.ofx build\Examples\Release\example-Invert.ofx build\Examples\Release\example-OpenGL.ofx build\Examples\Release\example-Rectangle.ofx build\Examples\Release\example-Test.ofx

garyo commented 4 months ago

Also see #140 from @SonyDennisAdams

garyo commented 4 months ago

GPUGain location should be fixed by c298169 (once it builds in CI)

SonyDennisAdams commented 4 months ago

@garyo OpenCL Buffer and Image support confirmed on Windows and Mac. The build option OFX_SUPPORTS_OPENCLRENDER is OFF by default, but needs to be ON for this example to work. Also, on Mac in Support/Plugins/CMakeLists.txt I had to add "-framework OpenCL" otherwise I got link errors against the OpenCL host API (e.g., clBuildProgram).

revisionfx commented 3 months ago

Another company just asked me why this is in Support but not in Examples folder?

Pierre

garyo commented 3 months ago

This example was created by Blackmagic, who generously donated it to us. It uses the C++ support lib. An example that doesn't use the support lib would be very welcome.