Fix issues with Choice and StrChoice params, per #146

AcademySoftwareFoundation / openfx

OpenFX effects API

Other

419 stars 122 forks source link

Fix issues with Choice and StrChoice params, per #146 #147

Closed garyo closed 7 months ago

garyo commented 8 months ago

Set defaults for StrChoice params in examples
Update doc to say that Choice and StrChoice params should use first defined option if the plugin doesn't specify a default
Fix plugin grouping for Support/Plugins/ChoiceParams

See also PR #133.

garyo commented 7 months ago

Note that you can just copy the pre-built plugin for testing from the action downloads page https://github.com/AcademySoftwareFoundation/openfx/actions/runs/8254227022?pr=147 The built plugin artifacts are at the bottom, Win/Linux/Mac.

Guido-assim commented 7 months ago

Note that you can just copy the pre-built plugin for testing from the action downloads page https://github.com/AcademySoftwareFoundation/openfx/actions/runs/8254227022?pr=147 The built plugin artifacts are at the bottom, Win/Linux/Mac.

I did not find the Mac plugins there. I tried the Choice Params plugin from main after the merge of the pull request and that works fine.

garyo commented 7 months ago

Ah, right -- this PR was from before I got all the plugins building for all OSes. Thanks for trying them on main.