search

AcademySoftwareFoundation / openfx

OpenFX effects API
Other
410 stars 120 forks source link

Fix missing GPU include #150

Closed jgoueslard closed 6 months ago

jgoueslard commented 6 months ago

Some variables like kOfxImageEffectPropOpenCLRenderSupported are used in ofxsImageEffect and are declared in ofxGPURender.h. So this file should always be included even if we build without OFX_SUPPORTS_OPENGLRENDER.

garyo commented 6 months ago

The Windows CI failure is nothing to do with this change, it's something wrong with the CUDA installer github action. Just FYI.

garyo commented 6 months ago

Note: we now require contributor sign-off on all commits. If you could re-push this branch with an amended commit message including "Signed-off-by: Author Name authoremail@example.com" then we can merge it. You can also do this automatically by using the -s flag (i.e., git commit -s).

jgoueslard commented 6 months ago

Hi, It's done, you can merge :)