search

AcademySoftwareFoundation / openvdb

OpenVDB - Sparse volume data structure and tools
http://www.openvdb.org/
Apache License 2.0
2.71k stars 660 forks source link

Fixed symbol visibility issues with explicit instantiation #1573

Open Idclip opened 1 year ago

Idclip commented 1 year ago

Signed-off-by: Nick Avramoussis 4256455+Idclip@users.noreply.github.com

Closes #1272

e4lam commented 1 year ago

~Have we tested using this on Windows? I'm missing how an OpenVDB DLL user can link against the instantiations if they're no longer declared as dllimport.~

EDIT: Ah I missed that we're now directly doing the import/exports of the instantiations. But perhaps it worries me a bit that we're redeclaring them with the same macro names.

Idclip commented 1 year ago

@danrbailey bumping this

EDIT: Ah I missed that we're now directly doing the import/exports of the instantiations. But perhaps it worries me a bit that we're redeclaring them with the same macro names.

Happy to use different names for the import/export specs