AcademySoftwareFoundation / openvdb

OpenVDB - Sparse volume data structure and tools
http://www.openvdb.org/
Mozilla Public License 2.0
2.62k stars 647 forks source link

[REQUEST] Add VFX Platform 2023 to CI build matrix #1627

Open jfpanisset opened 1 year ago

jfpanisset commented 1 year ago

There are now VFX Platform 2023 clang 14 and clang 15 versions of the ci-openvdb aswfdocker build containers available:

They could now be added to the CI build matrix:

https://github.com/AcademySoftwareFoundation/openvdb/blob/9a57c7e68e5de9ecfd05a98364dcfb8063f71186/.github/workflows/build.yml#L71

There has been a fair number of changes to these containers since VFX Platform 2022, feedback welcome if any issues crop up.

Idclip commented 1 year ago

Hey @jfpanisset thanks a lot for these. I've finally had a chance to look at bumping the VDB CI and am getting issues with GLFW3:

https://github.com/Idclip/openvdb/actions/runs/6287213295/job/17071469457

I'm assuming nothing has explicitly changed here? Can you confirm that the version of glfw installed should be the same for the 2023 containers?

Cheers!

jfpanisset commented 1 year ago

@Idclip Between the 2023 and 2023.1 releases of the aswf-docker containers, one of the changes that went in is that glfw is now installed as a Conan package instead of a direct build & install:

https://github.com/AcademySoftwareFoundation/aswf-docker/blob/16cbddb991fb8edb18af65797f2cd0d3a911da91/ci-openvdb/Dockerfile#L134

It is possible that somehow this didn't pull in the the expected glfw CMake files, or put them in a different place than before. The ci-vfxall container successfully builds OpenVDB, but I seen that the build failure is with vdb_view which I don't think is built by anything in aswf-docker, which may explain why this regression was missed.

I will take a look and try to find what is different between the ci-openvdb:2023 and ci-openvdb:2023.1 installs of glfw3 and see if there's a simple fix.

Idclip commented 1 year ago

Thanks @jfpanisset, switching from 15 (which uses 15.1) to 15.0 does seem to work https://github.com/Idclip/openvdb/actions/runs/6361210998/job/17275486301

I'll use 15.0 for now

Idclip commented 10 months ago

Hey @jfpanisset, have there been any updates on the GLFW issue?

jfpanisset commented 10 months ago

Unfortunately I was not able to get it resolved in time for the 2023.2 release, but now that I understand better what's going on, I'm hoping to get it resolved for 2024.0

Some of the Conan recipes we are using are making the assumption that CMake recipes it installs will only be used in the context of Conan, but we need those to work from "vanilla" CMake, which is what our ASWF projects use.

I'm still learning the details of how this works, and if I figure it out for 2024.0, I will try to backport to a 2023.3 release, or provide a simple script you can use the patch the CMake files in the 2023.2 container.

So I haven't forgotten, still working on it.