Removed Redundant Render Function Call

AcademySoftwareFoundation / openvdb

OpenVDB - Sparse volume data structure and tools

http://www.openvdb.org/

Apache License 2.0

2.71k stars 660 forks source link

Removed Redundant Render Function Call #1686

Open ganesh1828 opened 1 year ago

ganesh1828 commented 1 year ago

Due to mUpdates upper limit value check 2, render function is called twice from the loop in the view function in the Viewer.cc file. Changing its upper limit value check to 1 will results in calling render function only once.

linux-foundation-easycla[bot] commented 1 year ago

:x: - login: @ganesh1828 / name: Ganesh Suresh Kandepalli . The commit (26b67d0b2012150095e5fbf6ff39d50732fc1575, 71f405569db2599332c427cfdeb2efe33e404cd6) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

diiigle commented 1 year ago

Rings some alarm bells for me:

effectively a 1 line change, that would be "easy to approve"
no description provided
Why is there a binary blob committed, and then removed in a second commit? Just to place it in the history?!

smells fishy

ganesh1828 commented 1 year ago

@diiigle Binary was pushed by mistake, that's why I removed it. and description is provided now, you can check it.