Replace boost conversion_traits with std::common_type

AcademySoftwareFoundation / openvdb

OpenVDB - Sparse volume data structure and tools

http://www.openvdb.org/

Mozilla Public License 2.0

2.62k stars 647 forks source link

Replace boost conversion_traits with std::common_type #1688

Closed bpmckinnon closed 11 months ago

bpmckinnon commented 11 months ago

This appears to be a reasonable replacement for conversion_traits. It appeared that sfinae was kicking in at a few places with the conversion type since a few functions were passing in non-arithmetic types (like mat3 and vec3) as scalars. The enable_if was added to fail the incorrect function templates before common_type is compiled.

linux-foundation-easycla[bot] commented 11 months ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: bpmckinnon (fd4c370b22f983fd89fa7eac8d6a63ee493be45f)