Fix for potential crash when reading invalid .vdb files.

AcademySoftwareFoundation / openvdb

OpenVDB - Sparse volume data structure and tools

http://www.openvdb.org/

Mozilla Public License 2.0

2.62k stars 647 forks source link

Closed jmlait closed 11 months ago

jmlait commented 11 months ago

Original fix thanks to Matthias Ueberheide.

kmuseth commented 11 months ago

weird, one of the nanovdb unit-tests failed on Windows because it timed out! Never seen that error before ... @jmlait can you re-run that test?

Idclip commented 11 months ago

Looks like it segfaulted, it didn't time out

kmuseth commented 11 months ago

re-ran the test and it passed so it might have been a resource issue, like insufficient memory

Idclip commented 11 months ago

As far as I know your nanovdb_openvdb_unit_test target doesn't use any VDB IO anyway? So that crash was probably not related to this change.

I'd keep an eye out if it happens again in case it's a non-deterministic issue with the latest nanovdb changes

jmlait commented 11 months ago

Built 10.1 with this version and ran sop-based reg tests on it with no change in behaviour from before the change.