Open tetov opened 11 months ago
Hi @tetov, thanks for this! Can you sign-off your commit (git commit -s
) and we can accept this change
Hi @Idclip, I've just force pushed after git commit --amend -s
. Thanks!
@Idclip I see now that https://github.com/AcademySoftwareFoundation/openvdb/commit/922675c255bd3c413daf417aba63ef06ccadf2fe was also signed-off, am I missing something else?
I ran into the same issue brought up in #1658 while updating the conda-forge feedstock for openvdb.
On Windows and Python > 3.9
ssize_t
is undeclared.I opted to replace every ssize_t with Py_ssize_t but this could of course also have been done with a typedef or using. I'm open to other solutions.
I'm attaching two logs from the PR mentioned from conda-forge's CI.
Passes: win_64_numpy1.22python3.9.__cpython Azure CI [attached log file](https://github.com/AcademySoftwareFoundation/openvdb/files/13241116/win_64_numpy1.22python3.9.__cpython.log)
Fails: win_64_numpy1.22python3.10.__cpython Azure CI [attached log file](https://github.com/AcademySoftwareFoundation/openvdb/files/13241126/win_64_numpy1.22python3.10.__cpython.log)
The logs will be removed from Azure CI after 1 month.