search

AcademySoftwareFoundation / openvdb

OpenVDB - Sparse volume data structure and tools
http://www.openvdb.org/
Mozilla Public License 2.0
2.62k stars 647 forks source link

WIP: fVDB CI setup #1908

Open swahtz opened 1 week ago

swahtz commented 1 week ago

@danrbailey, I implemented the updates since the last attempt (merge master->feature/fvdb and feature/fvdb->fvdb_ci_setup) but I'm still triggering all the other tests. I manually cancelled them. Perhaps it is the changes I make here to .github/workflows?

danrbailey commented 1 week ago

@danrbailey, I implemented the updates since the last attempt (merge master->feature/fvdb and feature/fvdb->fvdb_ci_setup) but I'm still triggering all the other tests. I manually cancelled them. Perhaps it is the changes I make here to .github/workflows?

I wondered that too, I can't seem to find any reference docs on this to confirm this. Either way, I think now that you've merged your changes to these .github/workflow files to master, I don't think you need to modify either of these yaml files? From the diff, it looks like you're adding the fvdb/** line when it already exists?

swahtz commented 1 week ago

@danrbailey, I implemented the updates since the last attempt (merge master->feature/fvdb and feature/fvdb->fvdb_ci_setup) but I'm still triggering all the other tests. I manually cancelled them. Perhaps it is the changes I make here to .github/workflows?

I wondered that too, I can't seem to find any reference docs on this to confirm this. Either way, I think now that you've merged your changes to these .github/workflow files to master, I don't think you need to modify either of these yaml files? From the diff, it looks like you're adding the fvdb/** line when it already exists?

Oh yes, that is a mistake... a slight mismatch in the changes I was making. I'll make sure to fix that up.