search

AcademySoftwareFoundation / rawtoaces

RAW to ACES Utility
141 stars 47 forks source link

data path not relocateable #105

Open maxnbk opened 6 years ago

maxnbk commented 6 years ago

in acesrender.cpp, the illuminant and camera data path defaults to "/usr/local/include/rawtoaces/data/illuminant", but a build which uses a CMAKE_INSTALL_PREFIX to be installed elsewhere will not have data there. The default path for the data files should be parameterized by the passed CMAKE_INSTALL_PREFIX if present.

miaoqi commented 6 years ago

Hi,

Which OS did you install it on?

you can also use the environment variable of "AMPAS_DATA_PATH" to set up the path to the data.

Thanks!

maxnbk commented 6 years ago

So using AMPAS_DATA_PATH works. Basically same issue as this issue, because the other two env vars have no effect, but data path works for both purposes. https://github.com/ampas/rawtoaces/issues/104

IdrisMiles commented 5 years ago

setting AMPAS_DATA_PATH does not work for the cmf and training data.

These are still hardcoded to:

#define FILEPATH ("/usr/local/include/rawtoaces/data/")

Would it be possible to allow these to use AMPAS_DATA_PATH or their own unique env var?