search

AcademySoftwareFoundation / rawtoaces

RAW to ACES Utility
141 stars 47 forks source link

JSON Schema Validator always gives an error in the license field #91

Open andyp6 opened 7 years ago

andyp6 commented 7 years ago

I get a Null/String error for the 'license' field when validating JSON with custom and the provided specsens data. It can be ignored but obviously is not validating.

Message: Invalid type. Expected String but got Null. Schema path: properties/header/properties/license#/type

Maybe the field type should be:

"type": ["string", "null"]

miaoqi commented 7 years ago

Hi, thanks for the feedback. I went to these two site:

  1. https://jsonlint.com/
  2. https://jsonformatter.curiousconcept.com/

It looks our current schema and values are valid.

@KelSolaar Hi Thomas, can you take a look? maybe we should need to change it to ""type": ["string", "null"]"

andyp6 commented 7 years ago

I've opened a pull request for this as a license to use spec sens data doesn't appear to be mandatory and I can't see any potential issues.

KelSolaar commented 7 years ago

Sorry for missing that one!

I would argue that putting a license is mandatory at least from a technical perspective. The first thing a company does when using public open source software (or data) is usually to check the license in order to know if the software can be used. If a software has no license, it is typically avoided like highly dangerous plague :)

That was the thinking for having the license property mandatory.

andyp6 commented 7 years ago

I don't disagree :)

I was looking at it from the perspective of current JSON, non of which specifies a license and therefore does not validate using the schema provided in README.md

KelSolaar commented 7 years ago

I think we talked about it already on Slack. Dragging @aforsythe to the convo as it is important :)