search

AcademySoftwareFoundation / rez

An integrated package configuration, build and deployment system for software
https://rez.readthedocs.io
Apache License 2.0
939 stars 332 forks source link

Update type hint for the package_filter argument of ResolvedContext's constructor #1582

Closed brycegbrazen closed 10 months ago

brycegbrazen commented 10 months ago

Closes #1581

Updates type hint to be what is actually expected by ResolvedContext under the hood.

As noted by #1581, ResolvedContext expects a PackageFilterList rather than a PackageFilterBase when deserializing from a dict, so this PR improves the documentation to match that.

JeanChristopheMorinPerso commented 10 months ago

This makes sense to me, considering that the default type is a PackageFilterList as seen in the constructor:

https://github.com/AcademySoftwareFoundation/rez/blob/a5977da83f37973658650a7514bcfa78da438674/src/rez/resolved_context.py#L239