Open Dennis-Lehmann opened 8 months ago
Thanks for creating this issue @RegionStormer! If you have some time, could you test with #1475 to see if it fixes the issue? I think it does but a confirmation would help.
Using the changes from #1475 I can confirm that the error message does now provide the path to the exe:
18:09:10 WARNING Git-bash executable has been detected at c:\windows\system32\bash.exe, but this is probably not correct (google Windows Subsystem for Linux). Consider adjusting your searchpath, or use rez config setting plugins.shell.gitbash.executable_fullpath.
Also setting up a .rezconfig.py
with the following content, gets rid of the warning:
plugins = {
"shell": {
"gitbash": {
"executable_fullpath": R"C:\Program Files\Git\bin\bash.exe",
}
}
}
The path to bash.exe
is properly resolved, though requesting an empty environment using the gitbash shell results in the following issue:
PS C:\Users\Dennis> rez env --shell gitbash
You are now in a rez-configured environment.
bash: rezolve: command not found
>
Dennis@COMPUTER MINGW64 /c/Users/Dennis
$
Rez also is not available in that environment
[...]
Dennis@COMPUTER MINGW64 /c/Users/Dennis
$ rez -h
bash: rez: command not found
>
Dennis@COMPUTER MINGW64 /c/Users/Dennis
$
@Dennis-Lehmann can you add that comment in https://github.com/AcademySoftwareFoundation/rez/pull/1475 please?
When WSL is setup on a windows machine, rez will throw the following warning multiple times after executing
rez -h
or trying to runrez env --shell gitbash
The warning itself is good, but its missing vital information, as well as providing (possibly) false information to the user!
[...] has been detected at %s, [...]
plugins.shell.gitbash.executable_fullpath
as suggested, will not satisfy/silence the warningInstead of
gitbash
the setting forbash
needs to be edited, such as in the example below. Note: git is not required to be installed, its enough to point to some arbitrary path to silence the warning, I'm just using it as an example!Noteworthy here: Spaces in the path of
executable_fullpath
lead to an addtional error:Environment
To Reproduce
rez -h
orrez env --shell gitbash
in terminalExpected behavior
gitbash
shell-plugin should have an effect on related usages of the shellActual behavior
bash
shell-plugin need to be modified in order to change behaviour ofgitbash
shell-pluginexecutable_fullpath
lead to an addtional error)Here is the full output of
rez -h
: