search

AcademySoftwareFoundation / rez

An integrated package configuration, build and deployment system for software
https://rez.readthedocs.io
Apache License 2.0
920 stars 329 forks source link

Make gh-rez external link dynamic #1707

Closed BryceGattis closed 3 months ago

BryceGattis commented 3 months ago

Closes #1690. Applies suggested fix from @JeanChristopheMorinPerso.

BryceGattis commented 3 months ago

@JeanChristopheMorinPerso Question though: This change only affects the URL in the PR right? It seems to still point just to 'main' when I do a local Sphinx build. Might be something nice to note as a comment if so.

JeanChristopheMorinPerso commented 3 months ago

@BryceGattis do you think we should use file://... when not building on RTD and if the CI environment is not set? (CI is a commonly set environment variable by most CI systems).

BryceGattis commented 3 months ago

@JeanChristopheMorinPerso

The READTHEDOCS environment variable is only set when we push to GitHub right? Just confirming.

I'm unsure exactly what I would need to put in the config file going down the file://... approach as you mentioned.