Closed JeanChristopheMorinPerso closed 2 months ago
Attention: Patch coverage is 90.00000%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 58.30%. Comparing base (
f63031e
) to head (3f97be0
).
Files | Patch % | Lines |
---|---|---|
src/rez/system.py | 90.00% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I confirm this resolved #1732 for me.
ps: Someone needs to check out the macos py3.7 CI environment. It seems pretty broken.
Thanks @darkvertex for confirming! As for the macos builds, we'll have to fix them. The failures are caused by the new default macos-latest
, which is now macos-14
which themselves are M1 runners. And 3.7 was not compatible with macOS arm64.
Anyway, I'll probably fix the macos thing in another PR.
Fixes #1732
Add more logic in the shell detection code to handle a case where the parent PID is zero. This can happen when run from within a docker container with a non-interactive shell.
This was not necessarily a hard error. rez would just print an annoying error.
Before:
After: