Closed BryceGattis closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 57.91%. Comparing base (
36e0537
) to head (a9c7f32
). Report is 6 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@BryceGattis I'd prefer if we leave it as is for now.
@JeanChristopheMorinPerso No problem! What's the reasoning behind this? Just trying to cleanup the vendor folder to make #1668 easier whenever a decision is made.
Understood. My reasoning is that I think some of our vendored dependencies depend on enum. Last time I checked, it wasn't us that introduced in some deps.
So I think it's preferable to wait until we make a decision before changing our vendored deps too much.
Does that make sense?
@JeanChristopheMorinPerso Yep you're correct that our vendored dependencies rely on enum, but only to a minimal extent. There were only three usages in the repo and they were all doing a simple from rez.vendor.enum import Enum
, so I figured that just swapping this out and removing the enum
vendored library would be simpler than doing the work of finding out which version of enum we have vendored (as it is currently missing this information in the vendor/README.md
.
Additionally, there's about 10 uses of the standard library enum throughout rez code already, so we're already using the built-in enum anyways.
I also thought, regardless of which way we go with our vendoring approach, having less dependencies is better, so this would be helpful either way.
enum package is built in since Python 3.4. No need to vendor it now.