search

AcademySoftwareFoundation / rez

An integrated package configuration, build and deployment system for software
https://rez.readthedocs.io
Apache License 2.0
916 stars 328 forks source link

Shell type plugin can resolve incorrectly in rez.system on Linux. #1754

Closed cumulus-vfx closed 1 week ago

cumulus-vfx commented 1 month ago

This line in rez.system.System.shell https://github.com/AcademySoftwareFoundation/rez/blob/a13f7bb362cbb05e73f88e9f771c36005c1e9f4a/src/rez/system.py#L91

Will throw a TypeError always as you cant replace with str char's on a byte string

So this function will always fallback to use $SHELL first to wrangle the shell name

This can be inaccurate in a case where the SHELL env var is wrong for the current running parent shell of the rez process Where as if getting via ps is more reliable.

Environment

Issue still in latest release 3.1.1

parikshittiwari740 commented 1 month ago

Hey @JeanChristopheMorinPerso, I have a PR out for this linked to the ticket 😄

Sorry for tagging but I was not sure how/when the review is done and whether I am expected to do something after posting the PR. Please ignore my message if you guys are busy and I simply have to wait. Thanks!