Closed parikshittiwari740 closed 3 months ago
The committers listed above are authorized under a signed CLA.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 58.39%. Comparing base (
a13f7bb
) to head (839d5aa
). Report is 27 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The subprocess to get the current shell name would always return a bytes output. The subsequent string operations on that output would always fail with a TypeError.
~Using subprocess.run() along with its text flag will fix the issue at hand as well as bring the code in-line with python's recommendation of using run for all use cases it can handle. The current use case does not warrant a use for subprocess.communicate()~.
Closes #1754