Convert Windows registry queries to use `winreg` module

AcademySoftwareFoundation / rez

An integrated package configuration, build and deployment system for software

https://rez.readthedocs.io

Apache License 2.0

916 stars 328 forks source link

Convert Windows registry queries to use `winreg` module #1780

Open nrusch opened 1 week ago

nrusch commented 1 week ago

Python 3 adds a winreg module to the standard library to perform Windows registry queries using native APIs.

This change converts the rez registry queries to use the winreg API instead of executing cmd.exe and/or powershell and parsing their output.

linux-foundation-easycla[bot] commented 1 week ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: nrusch / name: Nathan Rusch (bf72ceb0ac36467caa59523dfbcea13a7dbdeb95)

nrusch commented 1 week ago

This may also fix #1467

JeanChristopheMorinPerso commented 1 week ago

Hi @nrusch , thanks for submitting this PR. We require all contributors to sign a CLA. You can look at the comment above from EasyCLA (https://github.com/AcademySoftwareFoundation/rez/pull/1780#issuecomment-2195487061) and follow the instructions. Let us know if you hit any problems.

nrusch commented 1 week ago

Yes, I'm aware of the CLA requirement. We are working on getting our Netflix corporate CLA working, so I'm waiting for a follow-up from people higher up the chain.

nrusch commented 6 days ago

OK, the CLA should be resolved now.