Add missing close button decorator to tool windows (missing on Windows builds). Fixes #109.

AcademySoftwareFoundation / xstudio

xSTUDIO is a modern, high performance and feature rich playback and review application designed for organisations and individuals in the post production, VFX and Animation industries.

Apache License 2.0

639 stars 83 forks source link

Add missing close button decorator to tool windows (missing on Windows builds). Fixes #109. #120

Open aloyisus opened 1 month ago

aloyisus commented 1 month ago

Adds a close button to tool panels e.g. Python Console, Notes etc, which is otherwise missing in a Windows build.

linux-foundation-easycla[bot] commented 1 month ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: aloyisus (f18a8efb868bc07cea4c7a8ad55d3a6f756cf7f5)

jonbragado commented 1 month ago

There is an issue with that, the notes and draw panel don´t show up, so your fix for the button doesnt work with xstudio-0.12.0 build for Windows.

aloyisus commented 1 month ago

Sorry for delay with replying @jonbragado. I am building 0.12.0 for Windows and the buttons are showing up on all panels including Notes and Drawing Tools, so I can't reproduce what you're seeing. Can you provide some more info? Here's a screengrab from my build with the close buttons added (also worth noting that I have not been able to test this on Linux).

xStudio_Win_12 0