search

AcademyTLV / Fundamentals-cycle-7

3 stars 6 forks source link

Split Retrofit creation with the creation of the service #1

Open gilgoldzweig opened 4 years ago

gilgoldzweig commented 4 years ago

https://github.com/AcademyTLV/Fundamentals-cycle-7/blob/7f3347f1ae286e4023f14ce96a313f766e25048b/app/src/main/java/com/android/academy/networking/RestClient.kt#L13

afrishberg commented 4 years ago

@gilgoldzweig can you explain? just extract the retrofit creation to a method? or do you mean split the logics completely?

gilgoldzweig commented 4 years ago

Just split into two methods so it's easy to create other services

On Thu, Nov 21, 2019, 22:54 afrishberg notifications@github.com wrote:

@gilgoldzweig https://github.com/gilgoldzweig can you explain? just extract the retrofit creation to a method? or do you mean split the logics completely?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AcademyTLV/Fundamentals-cycle-7/issues/1?email_source=notifications&email_token=AD563XHO6WX556LSOBW2RY3QU3YOXA5CNFSM4JPPULJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE3TU5A#issuecomment-557267572, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD563XGYGPWF247TIDN367LQU3YOXANCNFSM4JPPULJQ .