search

AcalephStorage / consul-alerts

A simple daemon to send notifications based on Consul health checks
GNU General Public License v2.0
826 stars 191 forks source link

Enhancement suggestion - Rocketchat support #212

Open andrecp opened 6 years ago

andrecp commented 6 years ago

Hi,

Would be great to have rocketchat support, should be very similar to current Slack or Mattermost plugins.

I will try to have a go on it if the idea sounds good.

Thanks

jhixson74 commented 6 years ago

On Sun, Dec 31, 2017 at 05:26:08AM +0000, André wrote:

Hi,

Would be great to have rocketchat support, should be very similar to current Slack or Mattermost plugins.

I will try to have a go on it if the idea sounds good.

Hi guys,

I had planned to do this soon. We have gone through several chat programs here, and each time I have written a plugin haha. We've finally settled on rocket chat. So if nobody is currently working on this, I can do it, otherwise I'll just sit back and watch ;-)

Thanks

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

Link: https://github.com/AcalephStorage/consul-alerts/issues/212

Gerrrr commented 6 years ago

Hi @jhixson74 @andrecp ,

Sounds like a great idea! Feel free to poke me if you need a review.

Best, Aleks

andrecp commented 6 years ago

Hi @jhixson74 , I was going to do it as a learning exercise over this weekend, how about I try to make some progress and then send you where I got?

jhixson74 commented 6 years ago

On Thu, Jan 04, 2018 at 05:42:42PM +0000, André wrote:

Hi @jhixson74 , I was going to do it as a learning exercise over this weekend, how about I try to make some progress and then send you where I got?

Sounds good. I'd be happy to review this as well.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Link: https://github.com/AcalephStorage/consul-alerts/issues/212#issuecomment-355348994

andrecp commented 6 years ago

I had less time than I thought I would have this weekend, here is the work in progress: https://github.com/andrecp/consul-alerts/pull/1 I still need to finish the implementation of the notifier itself, I've only started it.

I will you ping you guys in this thread again once I get further, hopefully until next Sunday I have it working.

Cheers

jhixson74 commented 6 years ago

On Mon, Jan 08, 2018 at 12:58:49AM +0000, André wrote:

I had less time than I thought I would have this weekend, here is the work in progress: andrecp#1 I still need to finish the implementation of the notifier itself, I've only started it.

I will you ping you guys in this thread again once I get further, hopefully until next Sunday I have it working.

How is this coming along? ;-)

Cheers

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Link: https://github.com/AcalephStorage/consul-alerts/issues/212#issuecomment-355867745

andrecp commented 6 years ago

Hey @jhixson74 sorry no advancements.

Last week I couldn't get time will try this week but can't promise.

Feel free to implement it, don't want to block you.

Cheers