search

AcalephStorage / consul-alerts

A simple daemon to send notifications based on Consul health checks
GNU General Public License v2.0
825 stars 191 forks source link

Slack VarOverride functionality doesn't work the slack url #251

Open moadqassem opened 5 years ago

moadqassem commented 5 years ago

Go version: go.11.1 OS: MacOS Mojave Consul Version: 1.4.2 Consul-Alerts Version: 0.5.0

Description:

The main reason to use the VarOverrides is to have different notifiers paths. When I am using slack profile, the notifier variables are actually not overriden, the reason for that is, the url filed in the SlackNotifier is ignored. for example: 


{
  "Interval": 10,
  "NotifList": {
    "slack":true
  },
  "VarOverrides": {
    "slack": {
      "url": "https://hooks.slack.com/xxx"
    }
  }
}```
moadqassem commented 5 years ago

Here is the PR which fixes the issue: https://github.com/AcalephStorage/consul-alerts/pull/252