AcalephStorage / consul-alerts

A simple daemon to send notifications based on Consul health checks
GNU General Public License v2.0
825 stars 191 forks source link

Namespacing: Multiple notifier/flapping/healthcheck/service settings #81

Open wernerb opened 9 years ago

wernerb commented 9 years ago

The usecase is that I want multiple consul handlers to run in response to alerts, but perhaps with different flapping-settings / healthchecks / services. A quick fix would be to run multiple consul-alerts daemons with a configurable prefix. This would mean making the primary key (e.g., consul-alerts) customizable at boot, allowing for multiple alerting daemons to run.

A perhaps better but more extensive solution would be to add namespacing support. I.e. the key tree in consul would look like:

consul-alerts
\-- space-first-config ....
      \-- consul-alerts keys......
\-- space-second-config  
      \-- consul-alerts keys......

Perhaps each namespace should be prefixed with "space-" (or something more creative) for backwards compatibility.

The idea is to have each namespace be completely separate (no inheritance etc settings)

darkcrux commented 8 years ago

Sounds useful. The second solution sounds much better. Will have a look at how big a change is needed for this.