Ensure secrets like GithubClientSecrets are not passed as environment variables to Kontinuous

AcalephStorage / kontinuous

The Kubernetes Continuous Integration & Delivery Platform (CI/CD) :arrows_counterclockwise:

Apache License 2.0

116 stars 9 forks source link

Closed darkcrux closed 8 years ago

darkcrux commented 8 years ago

sensitive data should not be passed to kontinuous via Environment variables. these can be added through k8s secrets instead.

madziefe commented 8 years ago

Supported in release 0.1.3. GithubClientID and GithubClientSecret are part of kontinuous-secrets

darkcrux commented 8 years ago

closing this. :)