search

AccelerateHS / accelerate-backend-kit

DEPRECATED: Simplified AST for Accelerate that makes it easy to build new backends
17 stars 2 forks source link

accelerate head (Trafo changes?) breaks backend-kit. #2

Closed eamsden closed 11 years ago

eamsden commented 11 years ago

accelerate-backend-kit commit: https://github.com/AccelerateHS/accelerate-backend-kit/commit/25d8870ea961391784e700c89e90786e8e12fa35

accelerate commit: https://github.com/AccelerateHS/accelerate/commit/0e32e97c45eaf8c7889013633ba9e74e3a2dca21

building accelerate-backend-kit/backend-kit fails with:

Data/Array/Accelerate/BackendKit/CompilerPipeline.hs:132:10: Couldn't match type accelerate-0.13.0.0:Data.Array.Accelerate.Trafo.Base.DelayedOpenAcc () a' withAST.OpenAcc () a' Expected type: Smt.Acc a -> AST.Acc a Actual type: Smt.Acc a -> accelerate-0.13.0.0:Data.Array.Accelerate.Trafo.Base.DelayedAcc a In the expression: convertAccWith $ Phase {recoverAccSharing = True, recoverExpSharing = True, floatOutAccFromExp = True, enableAccFusion = False, convertOffsetOfSegment = False} In an equation for `phase0': phase0 = convertAccWith $ Phase {recoverAccSharing = True, recoverExpSharing = True, floatOutAccFromExp = True, enableAccFusion = False, convertOffsetOfSegment = False}

tmcdonell commented 11 years ago

Yeah, sorry about that. The fusion pass now makes it explicit what should be delayed/manifest, rather than relying on the user calling some appropriate functions later on.

Since you'd disabled fusion anyway, for the time being I'd say just call the sharing recovery function straight up, which will give the old behaviour. I should think of a better way to do this.

eamsden commented 11 years ago

Fixed by the following two pull requests (can someone with authorization pull and close please?): https://github.com/AccelerateHS/accelerate-backend-kit/pull/3 https://github.com/AccelerateHS/accelerate/pull/88

mchakravarty commented 11 years ago

With both pull requests merged, this can be closed, can't it?

eamsden commented 11 years ago

Yes. On Apr 25, 2013 9:24 PM, "Manuel M T Chakravarty" notifications@github.com wrote:

With both pull requests merged, this can be closed, can't it?

— Reply to this email directly or view it on GitHubhttps://github.com/AccelerateHS/accelerate-backend-kit/issues/2#issuecomment-17050614 .