AccelerateHS / accelerate-llvm

LLVM backend for Accelerate
http://www.acceleratehs.org
Other
155 stars 50 forks source link

Update accelerate-llvm for the new annotation fields from AccelerateHS/accelerate#510 #74

Closed robbert-vdh closed 2 years ago

robbert-vdh commented 2 years ago

Description

This simply adds holes to make accelerate-llvm* compile again with the changes from https://github.com/AccelerateHS/accelerate/pull/510. Once that PR has been merged, the pinned commit in the stack.yaml files will need to be updated. I will be working on using these annotations to add more useful context to the Tracy integration after this.

Motivation and context

Having accelerate-llvm compile without any errors sounds pretty great.

How has this been tested?

With the same environment mentioned in the other PR. Since this doesn't change any functionality, it's only a matter of making sure it compiles under the supported GHC versions. That being said, the macOS CI jobs still fail because llvm-hs can't determine the version of LLVM installed by homebrew, and the Linux jobs fail because they mysteriously produce the wrong results just like they do on the current master branch. That probably needs to be fixed at some point.

Types of changes

Checklist:

robbert-vdh commented 2 years ago

I'll close this together with https://github.com/AccelerateHS/accelerate/pull/510 since these are incomplete versions of the features anyways. The final version can be found in these two branches:

https://github.com/robbert-vdh/accelerate/tree/feature/force-inline https://github.com/robbert-vdh/accelerate-llvm/tree/feature/tracy-annotations