AccelerateNetworks / NumberSearch

Line of business tooling for VOIP services.
https://acceleratenetworks.com/
GNU Affero General Public License v3.0
11 stars 1 forks source link

[BUG] Ops Order Typeahead not taking users to the order suggested #446

Closed danry25 closed 7 months ago

danry25 commented 9 months ago

What is broken? An order is recommended to me in Ops by the typeahead, yet when I click it no order is found

Expected behavior This should take me to order https://ops.acceleratenetworks.com/Home/Order/eb20c270-0113-47b2-a9e9-bb44e9c47bf1

Screenshots image

uncheckederror commented 7 months ago

This appears to be broken because the & character is getting escaped to &.

This bug occurred because we were getting the text out of the HTML element that you clicked on, using it's element.innerHTML property. This property includes any HTML escaping, formatting, and tags. What we really wanted was just the text displayed by this element. Luckily we can get that by using the element.textContent property which is how this bug was resolved.

You can read more about the options for getting the text out of an HTML element here: https://www.w3schools.com/jsref/prop_node_textcontent.asp

@danry25 this change is live please test and confirm the fix. @dunkeltron I would call this a funny bug.