search

AccelerationNet / access

A common lisp library to unify access to common dictionary-like data-structures
Other
86 stars 12 forks source link

Remove dependency on 'anaphora' + some portability fixes #15

Closed fjl closed 2 years ago

fjl commented 2 years ago

Merge this after #14

This removes the dependency on 'anaphora' because access only uses basic AIF / AWHEN, and these can easily be replaced by alexandria's IF-LET / WHEN-LET helpers. Just one less dependency to worry about.

The PR also includes a bunch of other fixes related to package definitions and a fix for a portability issue. I'm sorry for just dumping all of these changes in here, but please consider that you'd have to review many more PRs if I had split this up.

vindarel commented 2 years ago

Thanks for working on access. Great to see a lower number of dependencies.

What's the portability fix?

(@maintainer: the diff is large because of indentation fixes)

fjl commented 2 years ago

The portability thing is sorting the result of hash-table-keys.

bobbysmith007 commented 2 years ago

Thank you to the contributors here I don't do any common lisp these days unfortunately so its great to see you folks who are interested are contributing. If either of you wish to be maintainers of this project, please let me know. I would rather the project move forward than be stagnated by my lack of language use. Alternatively, please feel free to submit a patch updating the documentation to note that you are contributors, should you want such attribution.

fjl commented 2 years ago

If either of you wish to be maintainers of this project, please let me know. I would rather the project move forward than be stagnated by my lack of language use. Alternatively, please feel free to submit a patch updating the documentation to note that you are contributors, should you want such attribution.

It looks like 'access' has already been forked to the 'sharplispers' org: https://github.com/sharplispers/access

This org takes care of unmaintained CL projects which are important to the well-being of the quicklisp dependency graph. I will open an issue there regarding this. If they agree, and you do too, the project could be transferred properly.